123456789_123456789_123456789_123456789_123456789_

Class: RuboCop::Cop::Style::CombinableDefined

Relationships & Source Files
Super Chains via Extension / Inclusion / Inheritance
Class Chain:
self, ::RuboCop::Cop::AutoCorrector, ::RuboCop::Cop::Base, ::RuboCop::ExcludeLimit, NodePattern::Macros, RuboCop::AST::Sexp
Instance Chain:
self, ::RuboCop::Cop::RangeHelp, ::RuboCop::Cop::Base, ::RuboCop::Cop::AutocorrectLogic, ::RuboCop::Cop::IgnoredNode, ::RuboCop::Util, RuboCop::AST::Sexp
Inherits: RuboCop::Cop::Base
Defined in: lib/rubocop/cop/style/combinable_defined.rb

Overview

Checks for multiple defined? calls joined by && that can be combined into a single defined?.

When checking that a nested constant or chained method is defined, it is not necessary to check each ancestor or component of the chain.

Examples:

# bad
defined?(Foo) && defined?(Foo::Bar) && defined?(Foo::Bar::Baz)

# good
defined?(Foo::Bar::Baz)

# bad
defined?(foo) && defined?(foo.bar) && defined?(foo.bar.baz)

# good
defined?(foo.bar.baz)

Constant Summary

::RuboCop::Cop::Base - Inherited

EMPTY_OFFENSES, RESTRICT_ON_SEND

::RuboCop::Cop::RangeHelp - Included

BYTE_ORDER_MARK, NOT_GIVEN

Class Attribute Summary

::RuboCop::Cop::AutoCorrector - Extended

support_autocorrect?

::RuboCop::Cop::Base - Inherited

.gem_requirements, .lint?,
.support_autocorrect?

Returns if class supports autocorrect.
.support_multiple_source?

Override if your cop should be called repeatedly for multiple investigations Between calls to on_new_investigation and on_investigation_end, the result of processed_source will remain constant.

Class Method Summary

::RuboCop::Cop::Base - Inherited

.autocorrect_incompatible_with

List of cops that should not try to autocorrect at the same time as this cop.
.badge

Naming.
.callbacks_needed, .cop_name, .department,
.documentation_url

Returns a url to view this cops documentation online.
.exclude_from_registry

Call for abstract Cop classes.
.inherited,
.joining_forces

Override and return the Force class(es) you need to join.
.match?

Returns true if the cop name or the cop namespace matches any of the given names.
.new,
.requires_gem

Register a version requirement for the given gem name.
.restrict_on_send

::RuboCop::ExcludeLimit - Extended

exclude_limit

Sets up a configuration option to have an exclude limit tracked.
transform

Instance Attribute Summary

::RuboCop::Cop::Base - Inherited

#active_support_extensions_enabled?, #always_autocorrect?, #config, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #processed_source, #string_literals_frozen_by_default?, #target_satisfies_all_gem_version_requirements?

::RuboCop::Cop::AutocorrectLogic - Included

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Instance Method Summary

::RuboCop::Cop::RangeHelp - Included

#add_range, #column_offset_between,
#contents_range

A range containing only the contents of a literal with delimiters (e.g.
#directions,
#effective_column

Returns the column attribute of the range, except if the range is on the first line and there’s a byte order mark at the beginning of that line, in which case 1 is subtracted from the column value.
#final_pos, #move_pos, #move_pos_str, #range_between, #range_by_whole_lines, #range_with_comments, #range_with_comments_and_lines, #range_with_surrounding_comma, #range_with_surrounding_space, #source_range

::RuboCop::Cop::Base - Inherited

#add_global_offense

Adds an offense that has no particular location.
#add_offense

Adds an offense on the specified range (or node with an expression) Unless that offense is disabled for this range, a corrector will be yielded to provide the cop the opportunity to autocorrect the offense.
#begin_investigation

Called before any investigation.
#callbacks_needed,
#cop_config

Configuration Helpers.
#cop_name, #excluded_file?,
#external_dependency_checksum

This method should be overridden when a cop’s behavior depends on state that lives outside of these locations:
#inspect,
#message

Gets called if no message is specified when calling add_offense or add_global_offense Cops are discouraged to override this; instead pass your message directly.
#name

Alias for Base#cop_name.
#offenses,
#on_investigation_end

Called after all on_…​
#on_new_investigation

Called before all on_…​
#on_other_file

Called instead of all on_…​
#parse

There should be very limited reasons for a Cop to do it’s own parsing.
#parser_engine,
#ready

Called between investigations.
#relevant_file?, #target_rails_version, #target_ruby_version, #annotate, #apply_correction, #attempt_correction,
#callback_argument

Reserved for Cop::Cop.
#complete_investigation

Called to complete an investigation.
#correct, #current_corrector,
#current_offense_locations

Reserved for Commissioner:
#current_offenses, #currently_disabled_lines, #custom_severity, #default_severity, #disable_uncorrectable, #enabled_line?, #file_name_matches_any?, #find_message, #find_severity, #range_for_original, #range_from_node_or_range,
#reset_investigation

Actually private methods.
#use_corrector

::RuboCop::Cop::AutocorrectLogic - Included

#disable_offense, #disable_offense_at_end_of_line, #disable_offense_before_and_after, #disable_offense_with_eol_or_surround_comment, #max_line_length,
#range_by_lines

Expand the given range to include all of any lines it covers.
#range_of_first_line, #range_overlaps_offense?, #string_continuation, #string_continuation?, #surrounding_heredoc, #surrounding_percent_array

::RuboCop::Cop::IgnoredNode - Included

#ignore_node, #ignored_node?, #part_of_ignored_node?, #ignored_nodes

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#defined_calls(nodes) (private)

[ GitHub ] 

  


# File 'lib/rubocop/cop/style/combinable_defined.rb', line 55



def defined_calls(nodes)
  nodes.filter_map do |defined_node|
    subject = defined_node.first_argument
    subject if subject.const_type? || subject.call_type?
  end
end


  








  

    #lhs_range_to_remove(term)   (private)
  



  

    


If the redundant defined? node is the LHS of an and node,
the term as well as the subsequent &&/and operator will be removed.



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/style/combinable_defined.rb', line 85



def lhs_range_to_remove(term)
  source = @processed_source.buffer.source

  pos = term.source_range.end_pos
  pos += 1 until source[..pos].end_with?(*OPERATORS)

  range_with_surrounding_space(
    range: term.source_range.with(end_pos: pos + 1),
    side: :right,
    newlines: false
  )
end


  








  

    #namespaces(nodes)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/style/combinable_defined.rb', line 62



def namespaces(nodes)
  nodes.filter_map do |node|
    if node.respond_to?(:namespace)
      node.namespace
    elsif node.respond_to?(:receiver)
      node.receiver
    end
  end
end


  








  

    #on_and(node)  
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/style/combinable_defined.rb', line 31



def on_and(node)
  # Only register an offense if all `&&` terms are `defined?` calls
  return unless (terms = terms(node)).all?(&:defined_type?)

  calls = defined_calls(terms)
  namespaces = namespaces(calls)

  calls.each do |call|
    next unless namespaces.any?(call)

    add_offense(node) do |corrector|
      remove_term(corrector, call)
    end
  end
end


  








  

    #remove_term(corrector, term)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/style/combinable_defined.rb', line 72



def remove_term(corrector, term)
  term = term.parent until term.parent.and_type?
  range = if term == term.parent.children.last
            rhs_range_to_remove(term)
          else
            lhs_range_to_remove(term)
          end

  corrector.remove(range)
end


  








  

    #rhs_range_to_remove(term)   (private)
  



  

    


If the redundant defined? node is the RHS of an and node,
the term as well as the preceding &&/and operator will be removed.



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/style/combinable_defined.rb', line 100



def rhs_range_to_remove(term)
  source = @processed_source.buffer.source

  pos = term.source_range.begin_pos
  pos -= 1 until source[pos, 3].start_with?(*OPERATORS)

  range_with_surrounding_space(
    range: term.source_range.with(begin_pos: pos - 1),
    side: :right,
    newlines: false
  )
end


  








  

    #terms(node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/style/combinable_defined.rb', line 49



def terms(node)
  node.each_descendant.select do |descendant|
    descendant.parent.and_type? && !descendant.and_type?
  end
end