123456789_123456789_123456789_123456789_123456789_

Class: RuboCop::Cop::Lint::UselessAccessModifier

Relationships & Source Files
Super Chains via Extension / Inclusion / Inheritance
Class Chain:
self, ::RuboCop::Cop::AutoCorrector, ::RuboCop::Cop::Base, ::RuboCop::ExcludeLimit, NodePattern::Macros, RuboCop::AST::Sexp
Instance Chain:
self, ::RuboCop::Cop::RangeHelp, ::RuboCop::Cop::Base, ::RuboCop::Cop::AutocorrectLogic, ::RuboCop::Cop::IgnoredNode, ::RuboCop::Util, RuboCop::AST::Sexp
Inherits: RuboCop::Cop::Base
Defined in: lib/rubocop/cop/lint/useless_access_modifier.rb

Overview

Checks for redundant access modifiers, including those with no code, those which are repeated, those which are on top-level, and leading public modifiers in a class or module body. Conditionally-defined methods are considered as always being defined, and thus access modifiers guarding such methods are not redundant.

This cop has ContextCreatingMethods option. The default setting value is an empty array that means no method is specified. This setting is an array of methods which, when called, are known to create its own context in the module’s current access context.

It also has MethodCreatingMethods option. The default setting value is an empty array that means no method is specified. This setting is an array of methods which, when called, are known to create other methods in the module’s current access context.

Examples:

# bad
class Foo
  public # this is redundant (default access is public)

  def method
  end
end

# bad
class Foo
  # The following is redundant (methods defined on the class'
  # singleton class are not affected by the private modifier)
  private

  def self.method3
  end
end

# bad
class Foo
  protected

  define_method(:method2) do
  end

  protected # this is redundant (repeated from previous modifier)

  [1,2,3].each do |i|
    define_method("foo#{i}") do
    end
  end
end

# bad
class Foo
  private # this is redundant (no following methods are defined)
end

# bad
private # this is useless (access modifiers have no effect on top-level)

def method
end

# good
class Foo
  private # this is not redundant (a method is defined)

  def method2
  end
end

# good
class Foo
  # The following is not redundant (conditionally defined methods are
  # considered as always defining a method)
  private

  if condition?
    def method
    end
  end
end

# good
class Foo
  protected # this is not redundant (a method is defined)

  define_method(:method2) do
  end
end

ContextCreatingMethods: concerning

# Lint/UselessAccessModifier:
#   ContextCreatingMethods:
#     - concerning

# good
require 'active_support/concern'
class Foo
  concerning :Bar do
    def some_public_method
    end

    private

    def some_private_method
    end
  end

  # this is not redundant because {concerning} created its own context
  private

  def some_other_private_method
  end
end

MethodCreatingMethods: delegate

# Lint/UselessAccessModifier:
#   MethodCreatingMethods:
#     - delegate

# good
require 'active_support/core_ext/module/delegation'
class Foo
  # this is not redundant because {delegate} creates methods
  private

  delegate :method_a, to: :method_b
end

Constant Summary

::RuboCop::Cop::Base - Inherited

EMPTY_OFFENSES, RESTRICT_ON_SEND

::RuboCop::Cop::RangeHelp - Included

BYTE_ORDER_MARK, NOT_GIVEN

Class Attribute Summary

::RuboCop::Cop::AutoCorrector - Extended

support_autocorrect?

::RuboCop::Cop::Base - Inherited

.gem_requirements, .lint?,
.support_autocorrect?

Returns if class supports autocorrect.
.support_multiple_source?

Override if your cop should be called repeatedly for multiple investigations Between calls to on_new_investigation and on_investigation_end, the result of processed_source will remain constant.

Class Method Summary

::RuboCop::Cop::Base - Inherited

.autocorrect_incompatible_with

List of cops that should not try to autocorrect at the same time as this cop.
.badge

Naming.
.callbacks_needed, .cop_name, .department,
.documentation_url

Returns a url to view this cops documentation online.
.exclude_from_registry

Call for abstract Cop classes.
.inherited,
.joining_forces

Override and return the Force class(es) you need to join.
.match?

Returns true if the cop name or the cop namespace matches any of the given names.
.new,
.requires_gem

Register a version requirement for the given gem name.
.restrict_on_send

::RuboCop::ExcludeLimit - Extended

exclude_limit

Sets up a configuration option to have an exclude limit tracked.
transform

Instance Attribute Summary

::RuboCop::Cop::Base - Inherited

#active_support_extensions_enabled?, #always_autocorrect?, #config, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #processed_source, #string_literals_frozen_by_default?, #target_satisfies_all_gem_version_requirements?

::RuboCop::Cop::AutocorrectLogic - Included

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Instance Method Summary

::RuboCop::Cop::RangeHelp - Included

#add_range,
#arguments_range

A range containing the first to the last argument of a method call or method definition.
#column_offset_between,
#contents_range

A range containing only the contents of a literal with delimiters (e.g.
#directions,
#effective_column

Returns the column attribute of the range, except if the range is on the first line and there’s a byte order mark at the beginning of that line, in which case 1 is subtracted from the column value.
#final_pos, #move_pos, #move_pos_str, #range_between, #range_by_whole_lines, #range_with_comments, #range_with_comments_and_lines, #range_with_surrounding_comma, #range_with_surrounding_space, #source_range

::RuboCop::Cop::Base - Inherited

#add_global_offense

Adds an offense that has no particular location.
#add_offense

Adds an offense on the specified range (or node with an expression) Unless that offense is disabled for this range, a corrector will be yielded to provide the cop the opportunity to autocorrect the offense.
#begin_investigation

Called before any investigation.
#callbacks_needed,
#cop_config

Configuration Helpers.
#cop_name, #excluded_file?,
#external_dependency_checksum

This method should be overridden when a cop’s behavior depends on state that lives outside of these locations:
#inspect,
#message

Gets called if no message is specified when calling add_offense or add_global_offense Cops are discouraged to override this; instead pass your message directly.
#name

Alias for Base#cop_name.
#offenses,
#on_investigation_end

Called after all on_…​
#on_new_investigation

Called before all on_…​
#on_other_file

Called instead of all on_…​
#parse

There should be very limited reasons for a Cop to do it’s own parsing.
#parser_engine,
#ready

Called between investigations.
#relevant_file?,
#target_gem_version

Returns a gems locked versions (i.e.
#target_rails_version, #target_ruby_version, #annotate, #apply_correction, #attempt_correction,
#callback_argument

Reserved for Cop::Cop.
#complete_investigation

Called to complete an investigation.
#correct, #current_corrector,
#current_offense_locations

Reserved for Commissioner:
#current_offenses, #currently_disabled_lines, #custom_severity, #default_severity, #disable_uncorrectable, #enabled_line?, #file_name_matches_any?, #find_message, #find_severity, #range_for_original, #range_from_node_or_range,
#reset_investigation

Actually private methods.
#use_corrector

::RuboCop::Cop::AutocorrectLogic - Included

#disable_offense, #disable_offense_at_end_of_line, #disable_offense_before_and_after, #disable_offense_with_eol_or_surround_comment, #eol_comment, #eol_comment_would_be_inside_literal?, #heredoc_range, #line_with_eol_comment_too_long?, #max_line_length, #multiline_ranges, #multiline_string?,
#range_by_lines

Expand the given range to include all of any lines it covers.
#range_of_first_line, #string_continuation?, #surrounding_heredoc?, #surrounding_percent_array?

::RuboCop::Cop::IgnoredNode - Included

#ignore_node, #ignored_node?, #part_of_ignored_node?, #ignored_nodes

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#access_modifier?(node) ⇒ Boolean (private)

[ GitHub ] 

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 200



def access_modifier?(node)
  node.bare_access_modifier? || node.method?(:private_class_method)
end


  








  

    #any_context_creating_methods?(child)  ⇒ Boolean  (private)
  



  

    
  





  


  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 302



def any_context_creating_methods?(child)
  # Some users still have `"included"` in their `ContextCreatingMethods` configurations,
  # so to prevent Ruby method redefinition warnings let's just skip this value.
  cop_config.fetch('ContextCreatingMethods', []).any? do |m|
    next if m == 'included'

    matcher_name = :"#{m}_block?"
    unless respond_to?(matcher_name)
      self.class.def_node_matcher matcher_name, <<~PATTERN
        (any_block (send {nil? const} {:#{m}} ...) ...)
      PATTERN
    end

    public_send(matcher_name, child)
  end
end


  








  

    #any_method_definition?(child)  ⇒ Boolean  (private)
  



  

    
  





  


  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 275



def any_method_definition?(child)
  cop_config.fetch('MethodCreatingMethods', []).any? do |m|
    # Some users still have `"included"` in their `MethodCreatingMethods` configurations,
    # so to prevent Ruby method redefinition warnings let's just skip this value.
    next if m == 'included'

    matcher_name = :"#{m}_method?"
    unless respond_to?(matcher_name)
      self.class.def_node_matcher matcher_name, <<~PATTERN
        {def (send nil? :#{m} ...)}
      PATTERN
    end

    public_send(matcher_name, child)
  end
end


  








  

    #autocorrect(corrector, node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 167



def autocorrect(corrector, node)
  range = range_by_whole_lines(node.source_range, include_final_newline: true)

  corrector.remove(range)
end


  








  

    #check_child_nodes(node, unused, cur_vis)   (private)
  



  

    


Metrics/PerceivedComplexity



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 214



def check_child_nodes(node, unused, cur_vis)
  node.child_nodes.each do |child|
    if child.send_type? && access_modifier?(child)
      cur_vis, unused = check_send_node(child, cur_vis, unused)
    elsif child.block_type? && included_block?(child)
      next
    elsif method_definition?(child)
      unused = nil
    elsif start_of_new_scope?(child)
      check_scope(child)
    elsif !child.defs_type?
      cur_vis, unused = check_child_nodes(child, unused, cur_vis)
    end
  end

  [cur_vis, unused]
end


  








  

    #check_new_visibility(node, unused, new_vis, cur_vis)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 244



def check_new_visibility(node, unused, new_vis, cur_vis)
  # does this modifier just repeat the existing visibility?
  if new_vis == cur_vis
    add_offense(node, message: format(MSG, current: cur_vis)) do |corrector|
      autocorrect(corrector, node)
    end
  else
    # was the previous modifier never applied to any defs?
    if unused
      add_offense(unused, message: format(MSG, current: cur_vis)) do |corrector|
        autocorrect(corrector, unused)
      end
    end
    # once we have already warned about a certain modifier, don't
    # warn again even if it is never applied to any method defs
    unused = node
  end

  [new_vis, unused]
end


  








  

    #check_node(node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 188



def check_node(node)
  return if node.nil?

  if node.begin_type?
    check_scope(node)
  elsif node.send_type? && node.bare_access_modifier?
    add_offense(node, message: format(MSG, current: node.method_name)) do |corrector|
      autocorrect(corrector, node)
    end
  end
end


  








  

    #check_scope(node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 204



def check_scope(node)
  cur_vis, unused = check_child_nodes(node, nil, :public)
  return unless unused

  add_offense(unused, message: format(MSG, current: cur_vis)) do |corrector|
    autocorrect(corrector, unused)
  end
end


  








  

    #check_send_node(node, cur_vis, unused)   (private)
  



  

    


Metrics/PerceivedComplexity



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 233



def check_send_node(node, cur_vis, unused)
  if node.bare_access_modifier?
    check_new_visibility(node, unused, node.method_name, cur_vis)
  elsif node.method?(:private_class_method) && !node.arguments?
    add_offense(node, message: format(MSG, current: node.method_name)) do |corrector|
      autocorrect(corrector, node)
    end
    [cur_vis, unused]
  end
end


  








  

    #class_or_instance_eval?(node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 184



def_node_matcher :class_or_instance_eval?, <<~PATTERN
  (any_block (send _ {:class_eval :instance_eval}) ...)
PATTERN


  








  

    #dynamic_method_definition?(node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 179



def_node_matcher :dynamic_method_definition?, <<~PATTERN
  {(send nil? :define_method ...) (any_block (send nil? :define_method ...) ...)}
PATTERN


  








  

    #eval_call?(child)  ⇒ Boolean  (private)
  



  

    
  





  


  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 296



def eval_call?(child)
  class_or_instance_eval?(child) ||
    child.class_constructor? ||
    any_context_creating_methods?(child)
end


  








  

    #included_block?(block_node)  ⇒ Boolean  (private)
  



  

    
  





  


  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 265



def included_block?(block_node)
  active_support_extensions_enabled? && block_node.method?(:included)
end


  








  

    #method_definition?(child)  ⇒ Boolean  (private)
  



  

    
  





  


  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 269



def method_definition?(child)
  static_method_definition?(child) ||
    dynamic_method_definition?(child) ||
    any_method_definition?(child)
end


  








  

    #on_begin(node)  
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 154



def on_begin(node)
  return if node.parent

  node.child_nodes.each do |child|
    next unless child.send_type? && access_modifier?(child)

    # This call always registers an offense for access modifier `child.method_name`
    check_send_node(child, child.method_name, true)
  end
end


  








  

    #on_block(node)  
    Also known as: #on_numblock, #on_itblock
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 145



def on_block(node)
  return unless eval_call?(node) || included_block?(node)

  check_node(node.body)
end


  








  

    #on_class(node)  
    Also known as: #on_module, #on_sclass
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 139



def on_class(node)
  check_node(node.body)
end


  








  

    #on_itblock(node)  
  



  

    


Alias for #on_block.



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 152



alias on_itblock on_block


  








  

    #on_module(node)  
  



  

    


Alias for #on_class.



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 142



alias on_module on_class


  








  

    #on_numblock(node)  
  



  

    


Alias for #on_block.



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 151



alias on_numblock on_block


  








  

    #on_sclass(node)  
  



  

    


Alias for #on_class.



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 143



alias on_sclass on_class


  








  

    #start_of_new_scope?(child)  ⇒ Boolean  (private)
  



  

    
  





  


  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 292



def start_of_new_scope?(child)
  child.type?(:module, :class, :sclass) || eval_call?(child)
end


  








  

    #static_method_definition?(node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/useless_access_modifier.rb', line 174



def_node_matcher :static_method_definition?, <<~PATTERN
  {def (send nil? {:attr :attr_reader :attr_writer :attr_accessor} ...)}
PATTERN