123456789_123456789_123456789_123456789_123456789_

Class: RuboCop::Cop::Lint::LiteralInInterpolation

Relationships & Source Files
Super Chains via Extension / Inclusion / Inheritance
Class Chain:
self, ::RuboCop::Cop::AutoCorrector, ::RuboCop::Cop::Base, ::RuboCop::ExcludeLimit, NodePattern::Macros, RuboCop::AST::Sexp
Instance Chain:
Inherits: RuboCop::Cop::Base
Defined in: lib/rubocop/cop/lint/literal_in_interpolation.rb

Overview

Checks for interpolated literals.

Note
Array literals interpolated in regexps are not handled by this cop, but by Lint/ArrayLiteralInRegexp instead.

Examples:

# bad
"result is #{10}"

# good
"result is 10"

Constant Summary

::RuboCop::Cop::Base - Inherited

DEPARTMENT_SEVERITIES, EMPTY_OFFENSES, RESTRICT_ON_SEND

::RuboCop::Cop::RangeHelp - Included

BYTE_ORDER_MARK, NOT_GIVEN

Class Attribute Summary

::RuboCop::Cop::AutoCorrector - Extended

::RuboCop::Cop::Base - Inherited

.gem_requirements, .lint?,
.support_autocorrect?

Returns if class supports autocorrect.

.support_multiple_source?

Override if your cop should be called repeatedly for multiple investigations Between calls to on_new_investigation and on_investigation_end, the result of processed_source will remain constant.

Class Method Summary

::RuboCop::Cop::Base - Inherited

.autocorrect_incompatible_with

List of cops that should not try to autocorrect at the same time as this cop.

.badge

Naming.

.callbacks_needed, .cop_name, .department,
.documentation_url

Returns a url to view this cops documentation online.

.exclude_from_registry

Call for abstract Cop classes.

.inherited,
.joining_forces

Override and return the Force class(es) you need to join.

.match?

Returns true if the cop name or the cop namespace matches any of the given names.

.new,
.requires_gem

Register a version requirement for the given gem name.

.restrict_on_send

Reserved for Commissioner.

::RuboCop::ExcludeLimit - Extended

exclude_limit

Sets up a configuration option to have an exclude limit tracked.

transform

Instance Attribute Summary

::RuboCop::Cop::Base - Inherited

::RuboCop::Cop::AutocorrectLogic - Included

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?,
#skipped_unsafe_correction_with_disable_uncorrectable?

Whether a correction exists but is skipped because it is unsafe in a safe autocorrect run, while --disable-uncorrectable asks for a todo comment on everything this run cannot correct.

#contextual_autocorrect_held_back?

When LSP is enabled or the --editor-mode option is on, it is considered as editing source code, and autocorrection with AutoCorrect: contextual will not be performed.

Instance Method Summary

::RuboCop::Cop::PercentLiteral - Included

::RuboCop::Cop::RangeHelp - Included

#add_range,
#arguments_range

A range containing the first to the last argument of a method call or method definition.

#column_offset_between,
#contents_range

A range containing only the contents of a literal with delimiters (e.g.

#directions,
#effective_column

Returns the column attribute of the range, except if the range is on the first line and there’s a byte order mark at the beginning of that line, in which case 1 is subtracted from the column value.

#final_pos

rubocop:disable-next Metrics/ParameterLists.

#move_pos, #move_pos_str, #range_between, #range_by_whole_lines, #range_with_comments, #range_with_comments_and_lines, #range_with_surrounding_comma, #range_with_surrounding_space, #source_range

::RuboCop::Cop::Interpolation - Included

::RuboCop::Cop::Base - Inherited

#add_global_offense

Adds an offense that has no particular location.

#add_offense

Adds an offense on the specified range (or node with an expression) Unless that offense is disabled for this range, a corrector will be yielded to provide the cop the opportunity to autocorrect the offense.

#begin_investigation

Called before any investigation.

#callbacks_needed

 — grouped under the Commissioner heading above.

#cop_config

Configuration Helpers.

#cop_name, #excluded_file?,
#external_dependency_checksum

This method should be overridden when a cop’s behavior depends on state that lives outside of these locations:

#inspect,
#message

Gets called if no message is specified when calling add_offense or add_global_offense Cops are discouraged to override this; instead pass your message directly.

#name

Alias for Base#cop_name.

#offenses,
#on_investigation_end

Called after all on_…​

#on_new_investigation

Called before all on_…​

#on_other_file

Called instead of all on_…​

#parse

There should be very limited reasons for a Cop to do it’s own parsing.

#parser_engine,
#ready

Called between investigations.

#relevant_file?,
#target_gem_version

Returns the version of a gem in the target, by default its locked version (i.e. from Gemfile.lock or gems.locked).

#target_rails_version, #target_ruby_version, #annotate, #apply_correction, #attempt_correction,
#callback_argument

Reserved for Cop::Cop.

#complete_investigation

Called to complete an investigation.

#correct, #covering_disabled_range, #current_corrector,
#current_offense_locations

Reserved for Commissioner:

#current_offenses, #currently_disabled_lines, #custom_severity, #default_severity, #disable_uncorrectable, #enabled_line?,
#enabled_lines?

A multi-line offense is suppressed by a directive on any line of its range, not only its first line, matching the intuition that the directive is attached to the offending code.

#file_name_matches_any?, #find_message, #find_severity, #matches_absolute_include_pattern?, #new_offense, #range_for_original, #range_from_node_or_range,
#reset_investigation

Actually private methods.

#suppression_reason

The -- reason on the directive that suppresses offenses on this range, or nil when the directive carries none.

#use_corrector

::RuboCop::Cop::AutocorrectLogic - Included

::RuboCop::Cop::IgnoredNode - Included

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#array_in_regexp?(node) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 57

def array_in_regexp?(node)
  grandparent = node.parent.parent
  node.array_type? && grandparent.regexp_type?
end

#autocorrected_value(node) (private)

rubocop:disable-next Metrics/MethodLength, Metrics/CyclomaticComplexity

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 79

def autocorrected_value(node)
  case node.type
  when :int
    node.children.last.to_i.to_s
  when :float
    node.children.last.to_f.to_s
  when :str
    autocorrected_value_for_string(node)
  when :sym
    autocorrected_value_for_symbol(node)
  when :array
    autocorrected_value_for_array(node)
  when :hash
    autocorrected_value_for_hash(node)
  when :nil
    ''
  else
    node.source.gsub('"', '\"')
  end
end

#autocorrected_value_for_array(node) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 153

def autocorrected_value_for_array(node)
  return node.source.gsub('"', '\"') unless node.percent_literal?

  contents_range(node).source.split.to_s.gsub('"', '\"')
end

#autocorrected_value_for_hash(node) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 159

def autocorrected_value_for_hash(node)
  hash_string = node.children.map do |child|
    key = autocorrected_value_in_hash(child.key)
    value = autocorrected_value_in_hash(child.value)
    "#{key}=>#{value}"
  end.join(', ')

  "{#{hash_string}}"
end

#autocorrected_value_for_string(node) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 132

def autocorrected_value_for_string(node)
  return node.source.delete_prefix('"').delete_suffix('"') unless node.value.valid_encoding?

  escape_string_content(node.children.last)
end

#autocorrected_value_for_symbol(node) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 142

def autocorrected_value_for_symbol(node)
  end_pos =
    node.loc.end ? node.loc.end.begin_pos : node.source_range.end_pos

  range_between(node.loc.begin.end_pos, end_pos).source.gsub('"', '\"')
end

#autocorrected_value_in_hash(node) (private)

rubocop:disable-next Metrics/MethodLength, Metrics/AbcSize

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 170

def autocorrected_value_in_hash(node)
  case node.type
  when :int
    node.children.last.to_i.to_s
  when :float
    node.children.last.to_f.to_s
  when :str
    escape_string_content(node.value.inspect)
  when :sym
    autocorrected_value_in_hash_for_symbol(node)
  when :array
    autocorrected_value_for_array(node)
  when :hash
    autocorrected_value_for_hash(node)
  else
    node.source.gsub('"', '\"')
  end
end

#autocorrected_value_in_hash_for_symbol(node) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 149

def autocorrected_value_in_hash_for_symbol(node)
  escape_string_content(node.value.inspect)
end

#correctable_value(begin_node, final_node) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 62

def correctable_value(begin_node, final_node)
  value = autocorrected_value(final_node)
  value = handle_special_regexp_chars(begin_node, value)
  return if starts_interpolation_after_hash_sign?(begin_node, value)

  value = escape_trailing_hash_sign(begin_node, value)

  # %W and %I split the content into words before expansion
  # treating each interpolation as a word component, so
  # interpolation should not be removed if the expanded value
  # contains a space character.
  return if in_array_percent_literal?(begin_node) && /\s|\A\z/.match?(value)

  value
end

#ends_heredoc_line?(node) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 201

def ends_heredoc_line?(node)
  grandparent = node.parent.parent
  return false unless grandparent&.dstr_type? && grandparent.heredoc?

  line = processed_source.lines[node.last_line - 1]

  line.size == node.parent.source_range.last_column
end

#escape_string_content(string) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 138

def escape_string_content(string)
  string.gsub(/[\\"]|#(?=[@{$])/, '\\\\\&')
end

#escape_trailing_hash_sign(begin_node, value) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 218

def escape_trailing_hash_sign(begin_node, value)
  following = processed_source.buffer.source[begin_node.source_range.end_pos]
  return value unless %w[{ @ $].include?(following) && unescaped_hash_sign?(value)

  "#{value.delete_suffix('#')}\\#"
end

#follows_literal_interpolation?(begin_node) ⇒ Boolean (private)

Each interpolation is checked against the original source, so correcting it in the same pass as a preceding one that leaves a (or nothing) could join that and a { from this one. It’s left for the next iteration instead.

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 232

def follows_literal_interpolation?(begin_node)
  previous = begin_node.left_sibling
  return false unless previous&.begin_type? && offending?(previous.children.last)

  value = correctable_value(previous, previous.children.last)
  value && (value.empty? || value.end_with?('#'))
end

#handle_special_regexp_chars(begin_node, value) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 100

def handle_special_regexp_chars(begin_node, value)
  parent_node = begin_node.parent

  return value unless parent_node.regexp_type? && parent_node.slash_literal? && value['/']

  # When a literal string containing a forward slash preceded by backslashes
  # is interpolated inside a regexp, the number of resultant backslashes in the
  # compiled Regexp is `(2(n+1) / 4)+1`, where `n` is the number of backslashes
  # inside the interpolation.
  # ie. 0-2 backslashes is compiled to 1, 3-6 is compiled to 3, etc.
  # This maintains that same behavior in order to ensure the Regexp behavior
  # does not change upon removing the interpolation.
  value.gsub(%r{(\\*)/}) do
    backslashes = Regexp.last_match[1]
    backslash_count = backslashes.length
    needed_backslashes = (2 * ((backslash_count + 1) / 4)) + 1

    "#{'\\' * needed_backslashes}/"
  end
end

#in_array_percent_literal?(node) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 210

def in_array_percent_literal?(node)
  parent = node.parent
  return false unless parent.type?(:dstr, :dsym)

  grandparent = parent.parent
  grandparent&.array_type? && grandparent.percent_literal?
end

#offending?(node) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 42

def offending?(node)
  node &&
    !special_keyword?(node) &&
    prints_as_self?(node) &&
    # Special case for `Layout/TrailingWhitespace`
    !(space_literal?(node) && ends_heredoc_line?(node)) &&
    # Handled by `Lint/ArrayLiteralInRegexp`
    !array_in_regexp?(node)
end

#on_interpolation(begin_node)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 27

def on_interpolation(begin_node)
  final_node = begin_node.children.last
  return unless offending?(final_node)
  return unless (expanded_value = correctable_value(begin_node, final_node))

  add_offense(final_node) do |corrector|
    next if final_node.dstr_type? # nested, fixed in next iteration
    next if follows_literal_interpolation?(begin_node)

    corrector.replace(final_node.parent, replacement(final_node, expanded_value))
  end
end

#prints_as_self?(node) ⇒ Boolean (private)

Does node print its own source when converted to a string?

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 190

def prints_as_self?(node)
  node.basic_literal? ||
    (COMPOSITE.include?(node.type) && node.children.all? { |child| prints_as_self?(child) })
end

#replacement(node, expanded_value) (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 240

def replacement(node, expanded_value)
  return expanded_value unless node.str_type? && !node.value.valid_encoding?

  node.source.delete_prefix('"').delete_suffix('"')
end

#space_literal?(node) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 195

def space_literal?(node)
  # `String#blank?` misses Unicode spaces such as U+3000 that
  # `Layout/TrailingWhitespace` treats as trailing whitespace.
  node.str_type? && node.value.valid_encoding? && node.value.match?(/\A[[:space:]]*\z/)
end

#special_keyword?(node) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 52

def special_keyword?(node)
  # handle strings like __FILE__
  (node.str_type? && !node.loc?(:begin)) || node.source_range.is?('__LINE__')
end

#starts_interpolation_after_hash_sign?(begin_node, value) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 121

def starts_interpolation_after_hash_sign?(begin_node, value)
  source = processed_source.buffer.source
  range = begin_node.source_range
  # Removing an empty value puts the `#` right before what follows the interpolation.
  following = "#{value}#{source[range.end_pos]}"
  return false unless following.start_with?('{', '@', '$')
  return false unless source[range.begin_pos - 1] == '#'

  unescaped_hash_sign?(source[0...range.begin_pos])
end

#unescaped_hash_sign?(text) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/lint/literal_in_interpolation.rb', line 225

def unescaped_hash_sign?(text)
  text.end_with?('#') && text.delete_suffix('#')[/\\*\z/].length.even?
end