123456789_123456789_123456789_123456789_123456789_

Class: RuboCop::Cop::Lint::IneffectiveAccessModifier

Relationships & Source Files
Super Chains via Extension / Inclusion / Inheritance
Class Chain:
self, ::RuboCop::Cop::Base, ::RuboCop::ExcludeLimit, NodePattern::Macros, RuboCop::AST::Sexp
Instance Chain:
self, ::RuboCop::Cop::Base, ::RuboCop::Cop::AutocorrectLogic, ::RuboCop::Cop::IgnoredNode, ::RuboCop::Util, RuboCop::AST::Sexp
Inherits: RuboCop::Cop::Base
Defined in: lib/rubocop/cop/lint/ineffective_access_modifier.rb

Overview

Checks for private or protected access modifiers which are applied to a singleton method. These access modifiers do not make singleton methods private/protected. private_class_method can be used for that.

Examples:

# bad
class C
  private

  def self.method
    puts 'hi'
  end
end

# good
class C
  def self.method
    puts 'hi'
  end

  private_class_method :method
end

# good
class C
  class << self
    private

    def method
      puts 'hi'
    end
  end
end

Constant Summary

::RuboCop::Cop::Base - Inherited

EMPTY_OFFENSES, RESTRICT_ON_SEND

Class Attribute Summary

::RuboCop::Cop::Base - Inherited

.gem_requirements, .lint?,
.support_autocorrect?

Returns if class supports autocorrect.
.support_multiple_source?

Override if your cop should be called repeatedly for multiple investigations Between calls to on_new_investigation and on_investigation_end, the result of processed_source will remain constant.

Class Method Summary

::RuboCop::Cop::Base - Inherited

.autocorrect_incompatible_with

List of cops that should not try to autocorrect at the same time as this cop.
.badge

Naming.
.callbacks_needed, .cop_name, .department,
.documentation_url

Returns a url to view this cops documentation online.
.exclude_from_registry

Call for abstract Cop classes.
.inherited,
.joining_forces

Override and return the Force class(es) you need to join.
.match?

Returns true if the cop name or the cop namespace matches any of the given names.
.new,
.requires_gem

Register a version requirement for the given gem name.
.restrict_on_send

::RuboCop::ExcludeLimit - Extended

exclude_limit

Sets up a configuration option to have an exclude limit tracked.
transform

Instance Attribute Summary

::RuboCop::Cop::Base - Inherited

#active_support_extensions_enabled?, #always_autocorrect?, #config, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #processed_source, #string_literals_frozen_by_default?, #target_satisfies_all_gem_version_requirements?

::RuboCop::Cop::AutocorrectLogic - Included

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Instance Method Summary

::RuboCop::Cop::Base - Inherited

#add_global_offense

Adds an offense that has no particular location.
#add_offense

Adds an offense on the specified range (or node with an expression) Unless that offense is disabled for this range, a corrector will be yielded to provide the cop the opportunity to autocorrect the offense.
#begin_investigation

Called before any investigation.
#callbacks_needed,
#cop_config

Configuration Helpers.
#cop_name, #excluded_file?,
#external_dependency_checksum

This method should be overridden when a cop’s behavior depends on state that lives outside of these locations:
#inspect,
#message

Gets called if no message is specified when calling add_offense or add_global_offense Cops are discouraged to override this; instead pass your message directly.
#name

Alias for Base#cop_name.
#offenses,
#on_investigation_end

Called after all on_…​
#on_new_investigation

Called before all on_…​
#on_other_file

Called instead of all on_…​
#parse

There should be very limited reasons for a Cop to do it’s own parsing.
#parser_engine,
#ready

Called between investigations.
#relevant_file?,
#target_gem_version

Returns a gems locked versions (i.e.
#target_rails_version, #target_ruby_version, #annotate, #apply_correction, #attempt_correction,
#callback_argument

Reserved for Cop::Cop.
#complete_investigation

Called to complete an investigation.
#correct, #current_corrector,
#current_offense_locations

Reserved for Commissioner:
#current_offenses, #currently_disabled_lines, #custom_severity, #default_severity, #disable_uncorrectable, #enabled_line?, #file_name_matches_any?, #find_message, #find_severity, #range_for_original, #range_from_node_or_range,
#reset_investigation

Actually private methods.
#use_corrector

::RuboCop::Cop::AutocorrectLogic - Included

#disable_offense, #disable_offense_at_end_of_line, #disable_offense_before_and_after, #disable_offense_with_eol_or_surround_comment, #eol_comment, #eol_comment_would_be_inside_literal?, #heredoc_range, #line_with_eol_comment_too_long?, #max_line_length, #multiline_ranges, #multiline_string?,
#range_by_lines

Expand the given range to include all of any lines it covers.
#range_of_first_line, #string_continuation?, #surrounding_heredoc?, #surrounding_percent_array?

::RuboCop::Cop::IgnoredNode - Included

#ignore_node, #ignored_node?, #part_of_ignored_node?, #ignored_nodes

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#access_modifier?(node) ⇒ Boolean (private)

[ GitHub ] 

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 102



def access_modifier?(node)
  node.bare_access_modifier? && !node.method?(:module_function)
end


  








  

    #check_node(node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 59



def check_node(node)
  return unless node&.begin_type?

  ineffective_modifier(node) do |defs_node, modifier|
    add_offense(defs_node.loc.keyword, message: format_message(modifier))
  end
end


  








  

    #correct_visibility?(node, modifier, ignored_methods)  ⇒ Boolean  (private)
  



  

    
  





  


  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 106



def correct_visibility?(node, modifier, ignored_methods)
  return true if modifier.nil? || modifier.method?(:public)

  ignored_methods.include?(node.method_name)
end


  








  

    #format_message(modifier)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 71



def format_message(modifier)
  visibility = modifier.method_name
  alternative = if visibility == :private
                  ALTERNATIVE_PRIVATE
                else
                  ALTERNATIVE_PROTECTED
                end
  format(MSG, modifier: visibility,
              line: modifier.source_range.line,
              alternative: alternative)
end


  








  

    #ineffective_modifier(node, ignored_methods = nil, modifier = nil, &block)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 84



def ineffective_modifier(node, ignored_methods = nil, modifier = nil, &block)
  node.each_child_node do |child|
    case child.type
    when :send
      modifier = child if access_modifier?(child)
    when :defs
      ignored_methods ||= private_class_method_names(node)
      next if correct_visibility?(child, modifier, ignored_methods)

      yield child, modifier
    when :kwbegin
      ignored_methods ||= private_class_method_names(node)
      ineffective_modifier(child, ignored_methods, modifier, &block)
    end
  end
end


  








  

    #on_class(node)  
    Also known as: #on_module
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 52



def on_class(node)
  check_node(node.body)
end


  








  

    #on_module(node)  
  



  

    


Alias for #on_class.



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 55



alias on_module on_class


  








  

    #private_class_method_names(node)   (private)
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 67



def private_class_method_names(node)
  private_class_methods(node).to_a.flatten.select(&:basic_literal?).map(&:value)
end


  








  

    #private_class_methods(node)  
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/lint/ineffective_access_modifier.rb', line 48



def_node_search :private_class_methods, <<~PATTERN
  (send nil? :private_class_method $...)
PATTERN