123456789_123456789_123456789_123456789_123456789_

Class: RuboCop::Cop::Performance::EndWith

Relationships & Source Files
Super Chains via Extension / Inclusion / Inheritance
Class Chain:
self, AutoCorrector, Base
Instance Chain:
self, ::RuboCop::Cop::RegexpMetacharacter, Base
Inherits: Base
  • Object
Defined in: lib/rubocop/cop/performance/end_with.rb

Overview

Identifies unnecessary use of a regex where String#end_with? would suffice.

This cop has SafeMultiline configuration option that true by default because end$ is unsafe as it will behave incompatible with end_with? for receiver is multiline string.

Examples:

# bad
'abc'.match?(/bc\Z/)
/bc\Z/.match?('abc')
'abc' =~ /bc\Z/
/bc\Z/ =~ 'abc'
'abc'.match(/bc\Z/)
/bc\Z/.match('abc')

# good
'abc'.end_with?('bc')

SafeMultiline: true (default)

# good
'abc'.match?(/bc$/)
/bc$/.match?('abc')
'abc' =~ /bc$/
/bc$/ =~ 'abc'
'abc'.match(/bc$/)
/bc$/.match('abc')

SafeMultiline: false

# bad
'abc'.match?(/bc$/)
/bc$/.match?('abc')
'abc' =~ /bc$/
/bc$/ =~ 'abc'
'abc'.match(/bc$/)
/bc$/.match('abc')

Cop Safety Information:

  • This will change to a new method call which isn’t guaranteed to be on the object. Switching these methods has to be done with knowledge of the types of the variables which rubocop doesn’t have.

Constant Summary

Instance Attribute Summary

::RuboCop::Cop::RegexpMetacharacter - Included

#safe_multiline?

Instance Method Summary

::RuboCop::Cop::RegexpMetacharacter - Included

#drop_end_metacharacter, #drop_start_metacharacter, #literal_at_end?, #literal_at_end_with_backslash_z?, #literal_at_end_with_dollar?, #literal_at_start?, #literal_at_start_with_backslash_a?, #literal_at_start_with_caret?

Instance Method Details

#on_csend(node)

Alias for #on_send.

[ GitHub ] 

  


# File 'lib/rubocop/cop/performance/end_with.rb', line 77



alias on_csend on_send


  








  

    #on_match_with_lvasgn(node)  
  



  

    


Alias for #on_send.



  



  [ GitHub ]


  

  


# File 'lib/rubocop/cop/performance/end_with.rb', line 78



alias on_match_with_lvasgn on_send


  








  

    #on_send(node)  
    Also known as: #on_csend, #on_match_with_lvasgn
  

  [ GitHub ]


  

  


# File 'lib/rubocop/cop/performance/end_with.rb', line 63



def on_send(node)
  return unless (receiver, regex_str = redundant_regex?(node))

  add_offense(node) do |corrector|
    receiver, regex_str = regex_str, receiver if receiver.is_a?(String)
    regex_str = drop_end_metacharacter(regex_str)
    regex_str = interpret_string_escapes(regex_str)
    dot = node.loc.dot ? node.loc.dot.source : '.'

    new_source = "#{receiver.source}#{dot}end_with?(#{to_string_literal(regex_str)})"

    corrector.replace(node, new_source)
  end
end