123456789_123456789_123456789_123456789_123456789_

Class: RuboCop::Cop::Performance::ChainArrayAllocation

Relationships & Source Files
Super Chains via Extension / Inclusion / Inheritance
Class Chain:
self, Base
Instance Chain:
self, Base
Inherits: Base
  • Object
Defined in: lib/rubocop/cop/performance/chain_array_allocation.rb

Overview

Identifies usages of array.compact.flatten.map { |x| x.downcase }. Each of these methods (compact, flatten, map) will generate a new intermediate array that is promptly thrown away. Instead it is faster to mutate when we know it’s safe.

Examples:

# bad
array = ["a", "b", "c"]
array.compact.flatten.map { |x| x.downcase }

# good
array = ["a", "b", "c"]
array.compact!
array.flatten!
array.map! { |x| x.downcase }
array

Constant Summary

Instance Method Summary

Instance Method Details

#enumerable_select_method?(node) ⇒ Boolean (private)

[ GitHub ]

  
# File 'lib/rubocop/cop/performance/chain_array_allocation.rb', line 73

def enumerable_select_method?(node)
  # NOTE: `QueryMethods#select` in Rails accepts positional arguments, whereas `Enumerable#select` does not.
  #        This difference can be utilized to reduce the knowledge requirements related to `select`.
  (node.block_type? || node.numblock_type?) && node.send_node.arguments.empty?
end

#on_send(node)

[ GitHub ]

  
# File 'lib/rubocop/cop/performance/chain_array_allocation.rb', line 60

def on_send(node)
  chain_array_allocation?(node) do |fm, sm|
    return if node.each_descendant(:send).any? { |descendant| descendant.method?(:lazy) }
    return if node.method?(:select) && !enumerable_select_method?(node.receiver)

    range = node.loc.selector.begin.join(node.source_range.end)

    add_offense(range, message: format(MSG, method: fm, second_method: sm))
  end
end